Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for incorrect chart props #2745

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Fixes for incorrect chart props #2745

merged 3 commits into from
Jan 26, 2024

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Jan 26, 2024

  • Fix the type signature of getPath in charts to match usage and documentation
  • Add the missing disableInlineStyles prop in common components. This exists in documentation but was missing in the TS common props.

Copy link

changeset-bot bot commented Jan 26, 2024

🦋 Changeset detected

Latest commit: e6b3857

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
victory-bar Patch
victory-canvas Patch
victory-core Patch
victory-area Patch
victory-axis Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-candlestick Patch
victory-chart Patch
victory-create-container Patch
victory-cursor-container Patch
victory-errorbar Patch
victory-group Patch
victory-histogram Patch
victory-legend Patch
victory-line Patch
victory-native Patch
victory-pie Patch
victory-polar-axis Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-vendor Patch
victory-voronoi-container Patch
victory-voronoi Patch
victory-zoom-container Patch
victory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2024 2:25pm

@carbonrobot carbonrobot changed the title ts migrate/props fixes Fixes for incorrect chart props Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants